SUMMER OF CODE: various patches [DRAFT]#3129
SUMMER OF CODE: various patches [DRAFT]#3129eMPee584 wants to merge 71 commits intoranger:masterfrom
Conversation
…abs-on-startup)
Ranger doesn't handle middle mouse clicks and treats the button as a scroll down event. I wanted to use the middle mouse button to close ranger
(much easier to distinguish - especially in folders with symlinks, which are also cyan by default)
02b03d5 to
24ad40d
Compare
Network and auto mounts did not go well with the previous default.
From the tmux 3.0 changelog: > * Add a -A flag to show-options to show parent options as well > * Do not document set-window-option and show-window-options. > set-option -w and show-options -w should be used instead. FIXES ranger#1739
.. so empty directories (0 entries) and directories with a cumulative size of 0 B can be differentiated.
.. so there's any indication of something happening. FIXME: Ideally, this would get its own Loader class.
(To test this, press F to freeze and CTRL-R to reset.. or go to a directory on which your user does not have +x permission..)
But please take care, here be 🐉 dragons..
.. just as in click()
Because a restored tab is appended to the fm.tabs dict, order will be different then before. So use get_tab_list() as titlebar module does.
.. so multipane layout gets rebuilt
.. enabled by setting new option `multipane_orientation` to `horizontal`
.. from command line. Not beautiful but works, at long last. FIXME: The pointer logic is utter _madness_! 🤪
…ycling border options
24ad40d to
930622c
Compare
assuming the later action to be more frequent..
( depends on the popular humanize library: https://github.com/python-humanize/humanize )
0fd5a13 to
c5c97c0
Compare
|
Ok test failed, where would I add this library to fix it? This screenshot of alexanderjeurissen/ranger_devicons#147 shows it on the left by the way: 
|
|
This is an impressive amount of work. Would you be interested in splitting this out into multiple PRs? It's really hard to review so many inter- and independent changes. If not, I'll pick all this apart myself and open PRs but that'll take ages and means we can't go through the review process. Pointing out which commits fix bugs so I can focus on those first would still be highly appreciated. |
|
Hey toon, sure that was my intention as well to chop it up into atomic PRs, this is kinda just my Do you have an idea about how to make the tests succeed with the addition of |
|
Predictably I'm still struggling to catch up to things so getting around to checking out your branch will likely take a while longer : (
I'm not sure what the problem is and the GHA logs have timed out on this PR so I can't check. What tests in particular are troublesome? |
|
Yeah, don't worry too much about it, lol.. I have a big exam 2nd week of april and until then, my main desktop machine with all my dev stuff stays off (following an annoying crash in january, after months of uptime) and I try to not get sucked into all matters FLOSS .. which is so hard xD That said, it would be great if the multipane PR #3154 would be merged, I consider that the most solid part of this, the rest was pretty much just to be transparent about what I was working on and giving the opportunity for feedback. |
[copied this over from the original PR (created 3 days ago) because it was not possible to rename the PR branch.. sorry for the additional notification noise..]
This is the first iteration of the consolidation of my very messy ranger tree 🎄😆
As school starts again tomorrow, I just wanted to get this out the door.. Most
patches should be in a good state and are thoroughly tested, some have room for
improvement. Let me know! I learned a lot about object oriented programming with
python, and discovered some new tools for development (after spending too much
time adding and removing
self.fm.notifystatements..):Oh and I still have to do the
make testthing, admittedly. This is the first iteration..Changelog (prefilled from list of commits)
gitbug withcherry-pick --abortlate sunday evening 🤦♂️.. luckily i was able to carve it from the vim undo file of the commit message - always commit with-v, it might safe a life]tmuxandentrftw btw, (re)starting hundreds of ranger panes to test edits, add debug statements and invokeimport pudb; pu.db– very awesome open source toolchain ⚙️ 💚 🥳