FM: don't expand paths in group_paths_by_dirname (#3118)#3142
Open
qrvd wants to merge 1 commit intoranger:masterfrom
Open
FM: don't expand paths in group_paths_by_dirname (#3118)#3142qrvd wants to merge 1 commit intoranger:masterfrom
qrvd wants to merge 1 commit intoranger:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ISSUE TYPE
x Bug fix
RUNTIME ENVIRONMENT
CHECKLIST
CONTRIBUTINGdocument has been read [REQUIRED]DESCRIPTION
#3118 (comment)
MOTIVATION AND CONTEXT
The
:trash %scommand will try to expand filenames even after the macro "%s" was expanded, which can for example cause it to delete the home folder when "%s" expands to the literal filename "~".#3118
#3118
TESTING
vejkse explains how to reproduce the bug, this commit fixes it.
It shouldn't affect anything else since only the trash command calls the affected methods
IMAGES / VIDEOS