WIP: fixes the script for updating cached payload sizes #20911
+6
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dledda-r7
reviewed
Jan 29, 2026
| # @return [Boolean] | ||
| def self.is_cached_size_accurate?(mod) | ||
| return true if mod.dynamic_size? && is_dynamic?(mod) | ||
| return true if mod.dynamic_size? || is_dynamic?(mod) |
Contributor
There was a problem hiding this comment.
Can you remind me the reason to this logic switch?
| # Initialize the simplified framework instance. | ||
| framework = Msf::Simple::Framework.create('DisableDatabase' => true) | ||
| exceptions = [] | ||
| framework = Msf::Simple::Framework.create({'DeferModuleLoads' => true}) |
Contributor
There was a problem hiding this comment.
Is this one the change we discussed to avoid having DATASTORE saved with save being fetched by the script?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20864
This PR addresses issue with
update_payload_cached_sizesscript. There has been some issues and inconsistencies with the script, leading to behavior when developers had to manually update cached sizes of payload, when CI failed. This PR tries to address the issue by unifying the way framework instance is created in CI and in the script. Furthermore, it takes into account thedynamiccached sizes and tries to forbid overwriting cached sizes by multiple payloads (i.e. staggers). As a bonus, it fixes a bug in PHP exec payload.This is work in progress, the initial fix seems to be working, further tests are necessary.
cached_sizesaccordingly