feat(graphql): make introspection configurable for dev vs prod environments - #9
Open
hosseiw wants to merge 1 commit into
Open
feat(graphql): make introspection configurable for dev vs prod environments#9hosseiw wants to merge 1 commit into
hosseiw wants to merge 1 commit into
Conversation
…nments - Add Environment and EnableIntrospection resolution in graphql/config - Enable introspection by default in development/local and disable in production - Support explicit overrides via ENABLE_INTROSPECTION and INTROSPECTION_ENABLED - Wire extension.Introspection conditionally in graphql/cmd/graphql - Add HTTP GET and OPTIONS routes for GraphQL compliance - Document introspection config in README.md and docker-compose.yaml - Add comprehensive unit tests for config resolution and introspection handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements configurable GraphQL introspection for the API gateway. Previously, introspection was disabled globally because
srv.Use(extension.Introspection{})was not registered on thehandler.New(...)server, preventing GraphQL Playground and GraphiQL from loading the schema and documentation.Changes
graphql/config/config.go):Environmentresolution fromENVIRONMENT,APP_ENV, orENV(defaults todevelopment).EnableIntrospectionto default totruein development/local environments andfalsein production (ENVIRONMENT=productionorprod).ENABLE_INTROSPECTIONandINTROSPECTION_ENABLED(true/false,1/0).graphql/cmd/graphql/main.go):newGraphQLHandlerto conditionally attachextension.Introspection{}.ENVIRONMENT: developmentindocker-compose.yaml.README.md.graphql/config/config_test.gocovering environment resolution, defaults, and flag precedence.graphql/cmd/graphql/main_test.goverifying schema introspection succeeds when enabled and fails when disabled.