Align pcm512x driver with upstream #873
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 457a0d6.
The main volume control in the PCM512x DAC has a range up to +24dB. This is dangerously loud and can potentially cause massive clipping in the output stages. Therefore this sets a sensible limit of 0dB for this control.
popcornmix
added a commit
that referenced
this pull request
Mar 7, 2015
Align pcm512x driver with upstream
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Mar 7, 2015
kernel: Align pcm512x driver with upstream See: raspberrypi/linux#873 kernel: dts: overlay: add mz61581, fix piscreen and rpi-display See: raspberrypi/linux#874 kernel: bcm2709: Increase the spare/free IRQs to match bcm2708 See: raspberrypi/linux#871 kernel: add support for Adafruit PiTFT See: raspberrypi/linux#858 firmware: dispserve: Allow vsync requests from multiple clients See: raspberrypi/userland#218 firmware: hello_fft: Update to version 3 See: http://www.aholme.co.uk/GPU_FFT/Main.htm
popcornmix
added a commit
to Hexxeh/rpi-firmware
that referenced
this pull request
Mar 7, 2015
kernel: Align pcm512x driver with upstream See: raspberrypi/linux#873 kernel: dts: overlay: add mz61581, fix piscreen and rpi-display See: raspberrypi/linux#874 kernel: bcm2709: Increase the spare/free IRQs to match bcm2708 See: raspberrypi/linux#871 kernel: add support for Adafruit PiTFT See: raspberrypi/linux#858 firmware: dispserve: Allow vsync requests from multiple clients See: raspberrypi/userland#218 firmware: hello_fft: Update to version 3 See: http://www.aholme.co.uk/GPU_FFT/Main.htm
neuschaefer
pushed a commit
to neuschaefer/raspi-binary-firmware
that referenced
this pull request
Feb 27, 2017
kernel: Align pcm512x driver with upstream See: raspberrypi/linux#873 kernel: dts: overlay: add mz61581, fix piscreen and rpi-display See: raspberrypi/linux#874 kernel: bcm2709: Increase the spare/free IRQs to match bcm2708 See: raspberrypi/linux#871 kernel: add support for Adafruit PiTFT See: raspberrypi/linux#858 firmware: dispserve: Allow vsync requests from multiple clients See: raspberrypi/userland#218 firmware: hello_fft: Update to version 3 See: http://www.aholme.co.uk/GPU_FFT/Main.htm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit in this PR reverts a previous commit that I made to the pcm512x driver that retricted the maximum volume range. I submitted this upstream but it was rejected as it was felt that a device driver should allow access to the full functionality of a device.
The second commit acheives the same limiting of the volume but from the iqaudio-dac driver instead.