Optional support for deployment targets: iOS 13 & OSX 10.15#81
Open
brunnerjosh wants to merge 1 commit intoraspu:masterfrom
Open
Optional support for deployment targets: iOS 13 & OSX 10.15#81brunnerjosh wants to merge 1 commit intoraspu:masterfrom
brunnerjosh wants to merge 1 commit intoraspu:masterfrom
Conversation
…rgets of iOS 13 and macOS 10.15.
12343bd to
102b0da
Compare
Collaborator
|
@brunnerjosh thanks for your contribution! I just checked the code and it builds and works as expected, however Codebeat is reporting 6 introduced issues, would it be possible for you to resolve these? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was updating my iOS app to have a minimum deployment target of iOS 13 and noticed that this library used a couple of deprecated APIs. I wanted to be able to pitch in and help modernize the code while still providing backward compatibility to existing users. In doing so, I left the majority of the code in place while simply wrapping the old/new API uses in
#availablechecks. Let me know if you'd like me to make any changes to my approach (refactoring out to helpers, etc.). Thanks!I did verify these changes locally in the iOS app I'm working on. Please let me know if there are any other verifications that you'd like to see. I'll attach a screenshot showing that the rendering doesn't change between iOS 12 and iOS 13.