fix: Error thrown when running `DocumentStore.initialize()` with an insecure connection when passing `AuthOptions`, even if no certificate was passed. #412

vxern · 2024-02-12T12:27:01Z

This PR fixes an error being thrown when DocumentStore.initialize() is run after creating a DocumentStore passing AuthOptions that do not contain a certificate.

In essence, this means that the user is forced to write the following verbose construction if they have a case where their certificate is possibly undefined:

let store: DocumentStore;
if (certificate) {
	store = new DocumentStore(host, database, { certificate, type: "pfx" });
} else {
	store = new DocumentStore(host, database);
}

store.initialize();

Instead of:

// This interface is agnostic to whether `certificate` is present or not, if it's not provided, it will just assume an insecure connection.
const store = new DocumentStore(host, database, { certificate, type: "pfx" });

store.initialize();

Given that this piece of code currently throws:

const store = new DocumentStore(host, database, { certificate: undefined, type: "pfx" });

store.initialize(); // Throws.

ml054 · 2024-03-19T06:48:34Z

@vxern Thanks for your contribution. :)

vxern · 2024-03-19T10:36:57Z

Absolutely, @ml054, thanks for looking into this.

fix: Error thrown even if no certificate passed.

aaceaf3

ppekrol requested a review from ml054 February 12, 2024 22:25

ml054 merged commit 92e1867 into ravendb:v5.4 Mar 19, 2024

vxern deleted the fix-options-error branch March 19, 2024 10:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Error thrown when running `DocumentStore.initialize()` with an insecure connection when passing `AuthOptions`, even if no certificate was passed. #412

fix: Error thrown when running `DocumentStore.initialize()` with an insecure connection when passing `AuthOptions`, even if no certificate was passed. #412

vxern commented Feb 12, 2024 •

edited

Loading

ml054 commented Mar 19, 2024

vxern commented Mar 19, 2024

fix: Error thrown when running DocumentStore.initialize() with an insecure connection when passing AuthOptions, even if no certificate was passed. #412

fix: Error thrown when running DocumentStore.initialize() with an insecure connection when passing AuthOptions, even if no certificate was passed. #412

Conversation

vxern commented Feb 12, 2024 • edited Loading

ml054 commented Mar 19, 2024

vxern commented Mar 19, 2024

fix: Error thrown when running `DocumentStore.initialize()` with an insecure connection when passing `AuthOptions`, even if no certificate was passed. #412

fix: Error thrown when running `DocumentStore.initialize()` with an insecure connection when passing `AuthOptions`, even if no certificate was passed. #412

vxern commented Feb 12, 2024 •

edited

Loading