@lafkpages this looks like it is doing all the right things :-)

Are the integration tests passing? (test_all)

Do they have a free tier for testing do you know?

I gave the CI a kick so we can see what that comes up with.

Thanks

Hi,

The service is free if you are a Movistar client and have a phone line with them, but on its own no, there is no free tier. CI failed due to linting but I think I just fixed that (hopefully).

Running go run ./fstest/test_all -backends movistarcloud fails so I'll get to work on that :)

Are the unit tests meant to take nearly an hour and a half to run? 😅

The service is free if you are a Movistar client and have a phone line with them, but on its own no, there is no free tier.

If we merge this, I'm going to need an account for the daily integration tests

CI failed due to linting but I think I just fixed that (hopefully).

I just clicked the button to run the CI

Running go run ./fstest/test_all -backends movistarcloud fails so I'll get to work on that :)

Great - let me know if you need help

Are the unit tests meant to take nearly an hour and a half to run? 😅

It depends on the provider. s3 rips through them in about 5 minutes.

For slow backends we might disable some of the tests.

The most important tests are backend/movistar, fs/operations and fs/sync

You can run these manually by cd into the directory and go test --verbose v -remote MyMovistarRemote:

Actually now they take about five hours to run but they all pass 🎉
I'll go ahead and mark this for review.

If we merge this, I'm going to need an account for the daily integration tests

Five hours a day of integration tests sounds a bit heavy to me... Also, at the moment this is implemented to require an auth cookie in rclone config. However, those don't last very long usually and I'm not sure what the best way to go would be. I believe there's a way to refresh the cookie automatically, but since this then generates a new cookie, it would require modifying the rclone config to persist it, and I'm not sure if that's the best way to go.