serve/http: add --disable-dir-list flag#9414
Open
acme wants to merge 1 commit into
Open
Conversation
Previously, GET requests for a directory URL always returned an HTML directory listing. There was no way to suppress this, unlike `serve webdav` which has supported --disable-dir-list since rclone#4191. This adds the same flag to `serve http`. When set, GET requests for directory URLs return 404 instead of a listing, while file downloads continue to work normally. Based on the approach suggested in rclone#6306. Fixes rclone#4000
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this change?
Previously, GET requests for a directory URL always returned an HTML directory listing. There was no way to suppress this, unlike
serve webdavwhich has supported --disable-dir-list for a while.This adds the same flag to
serve http. When set, GET requests for directory URLs return 404 instead of a listing, while file downloads continue to work normally.Based on the approach suggested in #6306.
Fixes #4000
Was the change discussed in an issue or in the forum before?
In #4000 and #6306.
Checklist