fs/fshttp: fix TestCertificates leaking client cert/key onto global config - #9843
Merged
Merged
Conversation
ncw
requested changes
Sep 3, 2026
ncw
left a comment
Member
There was a problem hiding this comment.
Thanks for fixing this up
I thought of a neater way of doing this - see inline
| @@ -177,6 +177,14 @@ func TestCertificates(t *testing.T) { | |||
Member
There was a problem hiding this comment.
I think a better fix would be to to use fs.AddConfig here which makes a private config just for this test.
PS No need for a massive comment :-)
halindrome
force-pushed
the
fix/testcertificates-cleanup-leak
branch
from
September 3, 2026 18:43
8a75eda to
b7e6c41
Compare
Author
|
Thanks - // Use a private config so the cert paths don't leak into other tests
ctx, ci := fs.AddConfig(context.TODO())Verified the leak is actually fixed rather than just moved: a throwaway test placed after |
ncw
force-pushed
the
fix/testcertificates-cleanup-leak
branch
from
September 5, 2026 10:58
557491c to
ffb10d0
Compare
…onfig This was fixed in this commit in an inelegant way 399bc6a fshttp: don't send --header values to other hosts on redirect The current commit fixes it properly with AddConfig. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
ncw
force-pushed
the
fix/testcertificates-cleanup-leak
branch
from
September 5, 2026 11:02
ffb10d0 to
5960e69
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out from the discussion in #9841, per @ncw's request there.
TestCertificatessetsci.ClientCert/ci.ClientKeyon the process-globalConfigInfo(the test'sctxcarries no override) to a path undert.TempDir(), and never resets them. Go removest.TempDir()on test cleanup, so any later test infs/fshttpthat builds a client viaNewTransportCustomfails trying to load a cert file that no longer exists.Harmless on its own -- it only surfaces once something else in the same test binary calls
NewClient/NewTransportCustomafterTestCertificatesruns, sincego testexecutes tests within a package in source order by default. I hit it while adding a new test to this package for #9841.One-line fix: reset both fields in a
defer, same pattern used elsewhere in this file.