fixed #9908 - fix noapplexattr to work with FSKit backend - #9909
Open
Eugeny wants to merge 1 commit into
Open
Conversation
ncw
requested changes
Sep 12, 2026
ncw
left a comment
Member
There was a problem hiding this comment.
I'm not sure about the backwards compatibly of this change, but we can make it macOS only easily enough. Maybe this should be fskit only with a new flag or opt I'm not sure. What do you think?
| func (fsys *FS) Setxattr(path string, name string, value []byte, flags int) (errc int) { | ||
| defer log.Trace(path, "name=%q, value=%q, flags=%d", name, value, flags)("errc=%d", &errc) | ||
| // #9908: simulate macFUSE behaviour (discard setxattr calls) - otherwise Finder cannot copy files onto the mount | ||
| if fsys.opt.NoAppleXattr && strings.HasPrefix(name, "com.apple.") { |
Member
There was a problem hiding this comment.
I think these should have if runtime.GOOS == "Darwin" && at the start otherwise we'll change the behaviour for Windows and Linux.
Author
There was a problem hiding this comment.
Updated so that the behaviour only changes on darwin + --noapplexattr + backend=fskit - this should a safe change given how it was basically not working at all with backend=fskit previously
Eugeny
force-pushed
the
9908-fskit-xattrs
branch
from
September 12, 2026 15:27
9ed3a26 to
3d5ba7f
Compare
Author
|
(sorry, I do not know if you get PR thread notifications without a re-review request) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change do?
See #9908 - this PR makes rclone match the old macFUSE behaviour where xattr syscalls were silently swallowed instead of returning ENOSYS. This fixes Finder being unable to copy anything onto the mount
I've tried returning ENOTSUP but that still causes FInder to fail
Linked issue
Fixes #9908
For new or changed backends
Checklist
test_allpasses for this backend and if submitting a new backend can provide a test account for the integration tester - see CONTRIBUTING.md.