Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update to jest 15#7625

Merged
cpojer merged 1 commit into
react:masterfrom
vjeux:jest15
Sep 1, 2016
Merged

Update to jest 15#7625
cpojer merged 1 commit into
react:masterfrom
vjeux:jest15

Conversation

@vjeux

@vjeux vjeux commented Aug 31, 2016

Copy link
Copy Markdown
Contributor

Jest 15 has just been released and is way more awesome: http://facebook.github.io/jest/blog/2016/09/01/jest-15.html

This pull request updates jest from version 12 to 15. Right now there's a fix in jest around Symbol ( jestjs/jest#1543 ) that hasn't been released yet, so this will break CI and cannot be merged it. But once it ships by the end of the day, we'll be good to go :)

See comments inline for all the changes I've done.

Comment thread package.json
"/.module-cache/",
"/react/build/"
],
"persistModuleRegistryBetweenSpecs": true,

@vjeux vjeux Aug 31, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jest upgrade path was so good. For each option that was deprecated, there was a big blob of text saying why and what was the new one I needed to use.

screen shot 2016-08-31 at 3 37 51 pm

Comment thread package.json Outdated
"ts"
],
"testRegex": "/__tests__/",
"moduleFileExtensions": ["js", "json", "node", "coffee", "ts"],

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that js, json and node are the default ones (that are needed to run the tests) and we need in addition coffee and ts for our integration testing with those.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, this will get reprinted too (I think it's justJSON.stringify(data, null, 2)). Let's change this and the one above to have newlines, like it currently is.

@vjeux

vjeux commented Aug 31, 2016

Copy link
Copy Markdown
Contributor Author
  • Removed ^ from regex
  • Reprinted package.json

@cpojer

cpojer commented Sep 1, 2016

Copy link
Copy Markdown
Contributor

Ok, 15.0.1 with a fix for the Symbol issue is out.

@cpojer cpojer closed this Sep 1, 2016
@cpojer cpojer reopened this Sep 1, 2016
@cpojer

cpojer commented Sep 1, 2016

Copy link
Copy Markdown
Contributor

oops! wrong button.

Jest 15 has just been released and is way more awesome: http://facebook.github.io/jest/blog/2016/09/01/jest-15.html

This pull request updates jest from version 12 to 15. Right now there's a fix in jest around Symbol that hasn't been released yet, so this will break CI and cannot be merged it. But once it ships by the end of the day, we'll be good to go :)

See comments inline for all the changes I've done.
@vjeux

vjeux commented Sep 1, 2016

Copy link
Copy Markdown
Contributor Author
  • Updated to jest 15.0.1
  • Moved the setup file in scripts/jest

This should be ready to go if someone wants to do a final review and do a stamp of approval :)

@cpojer cpojer merged commit 1bd55c8 into react:master Sep 1, 2016
@vjeux vjeux added this to the 15-next milestone Sep 1, 2016
@brigand

brigand commented Sep 1, 2016

Copy link
Copy Markdown
Contributor

You didn't change the gh review label btw.

@cpojer

cpojer commented Sep 1, 2016

Copy link
Copy Markdown
Contributor

woops! Sorry about that.

@zpao zpao modified the milestones: 15-next, 15.4.0 Oct 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants