Update to jest 15#7625
Merged
Merged
Conversation
| "/.module-cache/", | ||
| "/react/build/" | ||
| ], | ||
| "persistModuleRegistryBetweenSpecs": true, |
Contributor
Author
| "ts" | ||
| ], | ||
| "testRegex": "/__tests__/", | ||
| "moduleFileExtensions": ["js", "json", "node", "coffee", "ts"], |
Contributor
Author
There was a problem hiding this comment.
Note that js, json and node are the default ones (that are needed to run the tests) and we need in addition coffee and ts for our integration testing with those.
Contributor
There was a problem hiding this comment.
Actually, this will get reprinted too (I think it's justJSON.stringify(data, null, 2)). Let's change this and the one above to have newlines, like it currently is.
Contributor
Author
|
Contributor
|
Ok, 15.0.1 with a fix for the Symbol issue is out. |
Contributor
|
oops! wrong button. |
Jest 15 has just been released and is way more awesome: http://facebook.github.io/jest/blog/2016/09/01/jest-15.html This pull request updates jest from version 12 to 15. Right now there's a fix in jest around Symbol that hasn't been released yet, so this will break CI and cannot be merged it. But once it ships by the end of the day, we'll be good to go :) See comments inline for all the changes I've done.
Contributor
Author
This should be ready to go if someone wants to do a final review and do a stamp of approval :) |
Contributor
|
You didn't change the gh review label btw. |
Contributor
|
woops! Sorry about that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Jest 15 has just been released and is way more awesome: http://facebook.github.io/jest/blog/2016/09/01/jest-15.html
This pull request updates jest from version 12 to 15. Right now there's a fix in jest around Symbol ( jestjs/jest#1543 ) that hasn't been released yet, so this will break CI and cannot be merged it. But once it ships by the end of the day, we'll be good to go :)
See comments inline for all the changes I've done.