Feature Allow to change hours in input #2072
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyanas
approved these changes
Dec 16, 2020
|
|
Coll1ns
approved these changes
Dec 16, 2020
Coll1ns
approved these changes
Dec 16, 2020
ljharb
requested changes
Feb 24, 2021
|
Hi guys, is there any updates regarding this PR? I saw the issue ticket since last year and still opened |
|
@alvinjulian no update; if you'd like to add tests, please comment with a link to a branch (NOT a new PR) and i can pull them in and land it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually that PR adds the ability to change hours in an input string. Right now it is hardcoded to 12 hours.
How to reproduce
Provide a display format string with a time and try to change hours