Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@hsource
Copy link

@hsource hsource commented Feb 17, 2023

Motivation

We are trying to use the date-picker in a small position: fixed container with overflow: hidden. To make it escape its container using a portal, we use appendToBody={true}

This mostly works, but because the container is appended to the body in a static layout, the date picker becomes invisible once we scroll down the page.

Fix

  1. Add appendToBody="fixed" as an additional option, in addition to the normal booleans. Update all PropTypes

Testing

Added new automated Mocha tests that verify that position: 'fixed' gets added when appendToBody="fixed" is set

@hsource
Copy link
Author

hsource commented Oct 16, 2023

@ljharb Is there any chance you can review/merge this in? I'd appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant