Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: New architecture support for Android and iOS #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

feat: New architecture support for Android and iOS #655

wants to merge 21 commits into from

Conversation

j-piasecki
Copy link

@j-piasecki j-piasecki commented Feb 23, 2023 •
edited
Loading

PR adding New Architecture support to the library 🎉

We at Software Mansion have been working on improving support for the new architecture for quite a while now. If you need help with anything related to New Architecture, like:

or you just want to ask any questions, hit us up on [email protected]

Overview

This PR builds on top of #622 to implement the new arch support.

Besides the original PR, this one:

  • updates the Example to RN 0.71.3, alongside other dependencies
  • adds FabricExample app with the new arch enabled by default for easier testing
  • updates the configuration of the new architecture

I've tried to test the new arch in the Example app, but I've had issues with codegen generating native code based on the definitions from react-native-windows.

I understand if you don't want to include the FabricExample in case this were to be merged as it obfuscates the PR. I can remove it, but it makes testing easier.

Test Plan

I've tested Android & iOS on Example and FabricExample apps, checked that the web version also works, and made sure that tests pass.

I couldn't get the mac app to build either from the master branch or after upgrading React Native (although that's to be expected as the newest version of react-native-macos is 0.68 and I bumped react-native to 0.71).

I don't know whether the Windows app still works, as I don't have a Windows machine atm, so I just bumped the version of react-native-windows to the newest and hope it works.

@bulkinav
Copy link

@matt-oakes could you review this PR, please?

@mikehardy
Copy link
Contributor

I don't think Matt even works with react-native anymore, regardless he certainly doesn't contribute to this repo anymore.
I've been the prime mover for a while but have had other priorities for a bit, and may have other priorities for a while longer, apologies.

Anyone else so motivated is more than welcome to contribute a review + test this thing to move it forward though - that would be most welcome and should that happen, your contributions are how open source moves forward...

@mikehardy mikehardy added the help wanted Issues that you can help with label Mar 20, 2023
@jspizziri jspizziri mentioned this pull request Apr 29, 2023
Merged
@j-piasecki
Copy link
Author

@mikehardy Any chance you would find some time to review this now, assuming a while longer has passed 😄?

@intergalacticspacehighway intergalacticspacehighway mentioned this pull request Apr 4, 2024
Closed
@MrRefactor MrRefactor mentioned this pull request Jul 15, 2024
Merged
50 tasks
@AndrewGable
Copy link

We've been using this branch in production via patch-package for New Expensify for multiple months without issue, it'd be great to get this reviewed and released so the community at large can use this package with New Architecture!

Let us know if we can help in any way with resources to review, test, or help push this along. Thanks!

@mikehardy
Copy link
Contributor

@AndrewGable hearing that it works well for you is actually a really important step - I haven't had time to look at it obviously
If you were able to maybe create a new PR off this one that cleaned up the conflicts, that would certainly be a help as a first step, right now it can't be merged at all

@WoLewicki
Copy link

@mikehardy I merged the current master and it should be ready to progress now 🚀

@mikehardy
Copy link
Contributor

That's fantastic thank you @WoLewicki !
I won't let this decay again before merge I promise but it will have to sit while I am out of town for the week.

On the plus side I didn't do this today because I did get Notifee working with new arch / rn76. That was urgent and us done now at least

@NorseGaud
Copy link

Bump

@mikelros
Copy link

@mikehardy hoping you can take a look at it 🙏🏼

@icastillejogomez
Copy link

@mikehardy also hoping you can have time to review this!

@jachiliz
Copy link

@mikehardy bump 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matt-oakes matt-oakes Awaiting requested review from matt-oakes matt-oakes is a code owner

Assignees
No one assigned
Labels
help wanted Issues that you can help with
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@j-piasecki @bulkinav @mikehardy @AndrewGable @WoLewicki @NorseGaud @mikelros @icastillejogomez @jachiliz @intergalacticspacehighway