-
-
Notifications
You must be signed in to change notification settings - Fork 291
ValueEditor
should display two inputs when operator
is "between" or "notBetween"
#428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This is my thought..
I am still thinking about the answers for the last 2 questions. |
I started PR #431 that implements the two-input variation for the default You can try out the new build here: https://codesandbox.io/s/react-querybuilder-pr-431-test-cyj6rp?file=/src/App.tsx As to your questions:
The wrapper element has the
I added a
I went with "component"--see previous bullet.
It's not dynamic, it either displays for the given field/operator combination or it doesn't.
...and operator! :) Have a go with the CodeSandbox and let me know what you think. |
This looks perfect.. I will play around a bit with the CodeSandbox version you created. Thank you so very much @jakeboone02 ! |
@jakeboone02 - This was deployed to v6 on Jan 09th right ? |
I don't remember when it was originally published but yes, it's in v6. See #455. |
From discussion #427.
Questions:
listsAsArrays
prop enough to manage the way thehandleOnChange
prop is called from within the default component?parseNumbers
-ish prop for<QueryBuilder />
that attempts to setvalue
to a number?Similar enhancements (plus add/remove controls for a dynamic list of value editors) are needed for "in"/"notIn".
The text was updated successfully, but these errors were encountered: