You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I was creating a wrapper component around react-querybuilder with a story using storybook.
Due to the webpack configuration, the css was imported just fine in my app but was not included in the story, this was due to the webpack tree-shaking configuration.
Since react-querybuilder package.jsonsideEffects is false, the side effect css import was removed.
This was discussed at lenght in webpack in webpack/webpack#6571 but to prevent other one to spend to much time debugging this, I think a simple fix for this package would be to indicate that there is side effect in style files as indicated in webpack doc
Ooh, thanks for this! I probablydefinitely should have researched a little more before I added sideEffects: false to all the package.json files.
I'd like to look into it a little more before I implement your recommendation, but in meantime would you like to submit a PR that makes the change? It would need to include all 11 packages in the /packages folder. That way you'll get credit for the fix.
Hi! 👋
Firstly, thanks for your work on this project! 🙂
Today I used patch-package to patch
[email protected]
for the project I'm working on.I was creating a wrapper component around react-querybuilder with a story using storybook.
Due to the webpack configuration, the css was imported just fine in my app but was not included in the story, this was due to the webpack tree-shaking configuration.
Since react-querybuilder
package.json
sideEffects
isfalse
, the side effect css import was removed.This was discussed at lenght in webpack in webpack/webpack#6571 but to prevent other one to spend to much time debugging this, I think a simple fix for this package would be to indicate that there is side effect in style files as indicated in webpack doc
Here is the diff that solved my problem:
This issue body was partially generated by patch-package.
The text was updated successfully, but these errors were encountered: