Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix sideEffects for react-querybuilder #763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rbideau
Copy link
Contributor

@rbideau rbideau commented Aug 18, 2024

fixes #762

Only update for the react-querybuilder package since it's the only package with style files

Copy link

netlify bot commented Aug 18, 2024

Deploy Preview for react-querybuilder ready!

Name Link
🔨 Latest commit 411246d
🔍 Latest deploy log https://app.netlify.com/sites/react-querybuilder/deploys/66c1f8a9894d820008e63396
😎 Deploy Preview https://deploy-preview-763--react-querybuilder.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 60 (🔴 down 11 from production)
Accessibility: 89 (no change from production)
Best Practices: 92 (no change from production)
SEO: 88 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 411246d:

Sandbox Source
React Query Builder CI Template Configuration
React Query Builder Basic Template Configuration
React Query Builder Basic TypeScript Template Configuration
React Query Builder Drag-and-drop Template Configuration
React Query Builder Ant Design Template Configuration
React Query Builder Bootstrap Template Configuration
React Query Builder Bulma Template Configuration
React Query Builder Chakra UI Template Configuration
React Query Builder Fluent UI Template Configuration
React Query Builder Mantine Template Configuration
React Query Builder MUI/Material Template Configuration
React Query Builder Native Template Configuration
React Query Builder Next.js Template Configuration
React Query Builder Tremor Template Configuration

Copy link

codecov bot commented Aug 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (0cf4c4e) to head (411246d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #763   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          163       163           
  Lines         5021      5021           
  Branches      2444      2462   +18     
=========================================
  Hits          5021      5021           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jakeboone02
Copy link
Member

Thanks for this! I'll do a little research just to make sure I know exactly what's happening with the change and then probably just merge it as-is fairly quickly.

@jakeboone02 jakeboone02 merged commit ef6d5e6 into react-querybuilder:main Aug 19, 2024
13 checks passed
@jakeboone02
Copy link
Member

@all-contributors please add @rbideau for code.

Copy link
Contributor

@jakeboone02

I've put up a pull request to add @rbideau! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix package.json to have side effect for styles files
2 participants