fix line count error #583
Merged
fix line count error #583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #583 +/- ##
==========================================
- Coverage 96.04% 96.02% -0.03%
==========================================
Files 11 11
Lines 329 327 -2
Branches 130 130
==========================================
- Hits 316 314 -2
Misses 12 12
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I hope this will be merged soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #582, and likely #434 too, but I'm not sure about the latter.
The issue comes from an incorrect line count calculation which either counts the number of child nodes of the root of the AST or the number of newlines in the first node if it is the only node and it is text. This works for parsers that happen to output one root-child node per line, but not for others. What we want is the number of newlines in the whole text. There is also an off-by-one in the original calculation for the largest line number.