chore: Centralize TFM definitions in Directory.Build.props with platform-specific handling#103
Merged
glennawatson merged 2 commits intomainfrom Nov 13, 2025
Merged
Conversation
Co-authored-by: glennawatson <[email protected]>
Copilot
AI
changed the title
[WIP] Refactor TFMs setup in Directory.Build.props
Centralize TFM definitions in Directory.Build.props with platform-specific handling
Nov 13, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #103 +/- ##
=======================================
Coverage 80.33% 80.33%
=======================================
Files 8 8
Lines 651 651
Branches 64 64
=======================================
Hits 523 523
Misses 104 104
Partials 24 24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves Target Framework Moniker (TFM) definitions from individual
.csprojfiles toDirectory.Build.propsfor centralized management and platform-specific builds, aligning with ReactiveUI project standards.Changes
Directory.Build.props: Added TFM property definitionsNetCoreTargetFrameworks:netstandard2.0;net8.0;net9.0;net10.0(cross-platform)NetFrameworkTargetFrameworks:net462;net472(Windows only via$([MSBuild]::IsOsPlatform('Windows')))LibraryTargetFrameworks: Combines both for library projectsTestTargetFrameworks: Core TFMs + Framework TFMs, excludes netstandardReactiveUI.Extensions.csproj: Changed<TargetFrameworks>from hardcoded to$(LibraryTargetFrameworks)ReactiveUI.Extensions.Tests.csproj: Changed<TargetFrameworks>from hardcoded to$(TestTargetFrameworks)Behavior
Linux/macOS builds:
netstandard2.0;net8.0;net9.0;net10.0net8.0;net9.0;net10.0Windows builds:
netstandard2.0;net8.0;net9.0;net10.0;net462;net472net8.0;net9.0;net10.0;net462;net472Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
aka.mscurl -I -sSL --retry 5 --retry-delay 2 --connect-timeout 15 REDACTED(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.