Ensure Splat initialization in builder and tests #4110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added calls to InitializeSplat in ReactiveUIBuilder, builder extension, and RxApp static constructor to ensure Splat services are registered before core ReactiveUI services. Updated test classes to call RxApp.EnsureInitialized in constructors for consistent initialization. Also updated Splat package version in Directory.Packages.props.
Moved platform-specific ReactiveUIBuilder extension methods from platform namespaces to ReactiveUI.Builder, consolidating and standardizing their APIs. Updated tests and app code to use the new builder extension methods and removed legacy extension files. Added MultiPlatformReactiveUIBuilderExtensions for multi-platform configuration. This improves AOT compatibility and simplifies platform registration.
glennawatson
approved these changes
Aug 26, 2025
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(
What kind of change does this PR introduce?
update
What is the new behavior?
This pull request refactors platform-specific builder extension methods for Blazor and AndroidX, consolidating them under the
ReactiveUI.Buildernamespace and updating their APIs for consistency and improved scheduler configuration. It also updates related tests to use the new builder creation method, streamlining service registration and test setup. Minor dependency and warning suppression updates are included.Platform Extension Refactor and Consolidation:
BlazorReactiveUIBuilderExtensionsandAndroidXReactiveUIBuilderExtensionsin theReactiveUI.Buildernamespace, providing consistent APIs for configuring platform schedulers and modules. These replace the older extension files and introduce properties for main thread schedulers.ReactiveUIBuilderBlazorExtensions.csandReactiveUIBuilderAndroidXExtensions.csfrom platform-specific namespaces, migrating their functionality to the new consolidated location.Test Suite Modernization:
locator.CreateReactiveUIBuilder()instead of the previouslocator.CreateBuilder()method, and replaced direct calls toAppBuilder.ResetBuilderStateForTests()withSplat.Builder.AppBuilder.ResetBuilderStateForTests(). This change ensures tests use the new builder API and maintain proper isolation.Dependency and Warning Updates:
SplatVersionproperty inDirectory.Packages.propsfrom15.5.3to16.0.1to use the latest version.CA1510to theNoWarnproperty inDirectory.build.propsto suppress a new code analysis warning.AOT Test Initialization:
RxApp.EnsureInitialized()is called in the constructor ofViewLocatorAOTMappingTeststo guarantee ReactiveUI is initialized for AOT mapping tests.What might this PR break?
N/A new unreleased feature
Please check if the PR fulfills these requirements
Other information: