Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Jul 19, 2019. It is now read-only.

comments.json in the wrong place? #67

Closed
robbyemmert opened this issue Aug 17, 2015 · 3 comments
Closed

comments.json in the wrong place? #67

robbyemmert opened this issue Aug 17, 2015 · 3 comments

Comments

@robbyemmert
Copy link

According to the tutorial here: http://facebook.github.io/react/docs/tutorial.html, comments.json is supposed to be in public/comments.json. The POST action is reading/writing comments.json in the root directory.

@zpao
Copy link
Member

zpao commented Aug 17, 2015

Eh, the tutorial and the server portion here overlap. So it's right. But then it's wrong :(

The first few steps of the tutorial can be done without a server but once you get to POSTing, you need the server. The endpoint is just /comments.json so for those first few steps, GETting from public/ works. We really do need to clean up the tutorial, maybe just make the server part properly integrated.

I'm going to close out because there's no quick fix and requires a full pass on this. But we are aware of the issue. Thanks for bringing it up and sorry that it caused confusion.

@zpao zpao closed this as completed Aug 17, 2015
@robbyemmert
Copy link
Author

Actually, I got comments.json saving and loading to the right place with a pretty quick fix. Hopefully it helps. See my pull request #69. Thanks!

@robbyemmert
Copy link
Author

By the way, thanks for the tutorial, it was a great intro to React!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants