Comments.json saving to the correct place #69
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks! |
|
I think I signed up successfully. If it didn't go through for some reason, just let me know. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
I actually want to leave it where it is right now and have it treated more like a database (which is what we're doing anyway, and you'd never put your db in the public folder). I'd much prefer #48 gets done and we have an API endpoint that doesn't look like an actual file name. I appreciate you taking the time though! |
Comments.json would save to the root folder, while the tutorial had us serving it from the /public folder (which is best practice anyway). So this pull request just moves comments.json to the /public folder to avoid confusion. Everything works nicely now :).