This repository was archived by the owner on Jul 19, 2019. It is now read-only.
Heroku button #45
Merged
Heroku button #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
March 27, 2015 18:24
| puts 'Server started: http://localhost:3000/' | ||
| port = ENV['PORT'].nil? ? 3000 : ENV['PORT'].to_i | ||
|
|
||
| puts "Server started: http://localhost:#{port}/" |
There was a problem hiding this comment.
Can you do the same for the go server and make sure it outputs the right port?
|
I really like this idea. A couple additional things...
|
|
@zpao I did test it on heroku with my fork as best as possible. I'm happy to fix things if it doesn't work though for some reason (or at least try to get others to fix it). Otherwise I fixed the other issues raised in the PR. |
|
👍 Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add's a Heroku Button so people can experiment w/o having to install anything locally.