Update server.php #50
Conversation
This change allows requests for comments.json with a timestamp param at the end, which is how React requests it.
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks! |
|
I have now signed the CLA. |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
| @@ -21,7 +21,7 @@ function routeRequest() | |||
| case '/': | |||
| echo file_get_contents('./public/index.html'); | |||
| break; | |||
| case '/comments.json': | |||
| case (preg_match('/comments.json*/', $_SERVER["REQUEST_URI"]) ? true : false): | |||
There was a problem hiding this comment.
Oy that's a hacky case. Let's just drop the whole switch and just use if
|
Just going to take as is and change myself - somebody else hit this today and I'd rather get it all resolved sooner rather than later. Thanks again for filing and getting this going! |
|
Thanks, Paul! |
This change allows requests for comments.json with a timestamp param at the end, which is how React requests it.