Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add API for determining the resolved addresses to which this client should connect #3687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 27, 2025

Conversation

violetagg
Copy link
Member

No description provided.

@violetagg violetagg added the type/enhancement A general enhancement label Mar 19, 2025
@violetagg violetagg added this to the 1.2.5 milestone Mar 19, 2025
Copy link
Member

@chemicL chemicL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just left two questions.

Signed-off-by: Violeta Georgieva <[email protected]>
Copy link
Contributor

@rstoyanchev rstoyanchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Possibly the BiFunction could be a an interface, which can document expectations of implementations and also makes it discoverable.

Signed-off-by: Violeta Georgieva <[email protected]>
@violetagg
Copy link
Member Author

@chemicL @rstoyanchev I extracted the BiFunction as an interface. PTAL

Signed-off-by: Violeta Georgieva <[email protected]>
@violetagg
Copy link
Member Author

Let me merge this one. We can follow up if needed.

@violetagg violetagg merged commit 73c01e6 into 1.2.x Mar 27, 2025
14 checks passed
@violetagg violetagg deleted the resolved-addr-selector branch March 27, 2025 09:18
violetagg added a commit that referenced this pull request Mar 27, 2025
Signed-off-by: Violeta Georgieva <[email protected]>
violetagg added a commit that referenced this pull request Mar 27, 2025
Signed-off-by: Violeta Georgieva <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants