-
Notifications
You must be signed in to change notification settings - Fork 667
Add API for determining the resolved addresses to which this client should connect #3687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…hould connect Signed-off-by: Violeta Georgieva <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just left two questions.
reactor-netty-core/src/main/java/reactor/netty/transport/ClientTransportConfig.java
Outdated
Show resolved
Hide resolved
reactor-netty-core/src/main/java/reactor/netty/transport/TransportConnector.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Violeta Georgieva <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Possibly the BiFunction could be a an interface, which can document expectations of implementations and also makes it discoverable.
Signed-off-by: Violeta Georgieva <[email protected]>
@chemicL @rstoyanchev I extracted the |
Signed-off-by: Violeta Georgieva <[email protected]>
Let me merge this one. We can follow up if needed. |
Signed-off-by: Violeta Georgieva <[email protected]>
Signed-off-by: Violeta Georgieva <[email protected]>
No description provided.