Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Test against PHP 7.3 on travis #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 10, 2018
Merged

Test against PHP 7.3 on travis #174

merged 2 commits into from
Dec 10, 2018

Conversation

WyriHaximus
Copy link
Member

No description provided.

@WyriHaximus WyriHaximus requested review from jsor, cboden and clue October 26, 2018 15:26
@clue
Copy link
Member

clue commented Oct 27, 2018

The build log indicates that installing ext-event via PECL currently fails, is this something you're going to look into? 👍

@WyriHaximus
Copy link
Member Author

@clue currently looking into it 👍

@WyriHaximus
Copy link
Member Author

@clue @jsor Ok disabled all failing event loops on PHP 7.3. Will check them once 7.3 is out and PHP 7.x loops have been updated. This PR is ready for review. Should I rebase or are the current commits fine?

@WyriHaximus
Copy link
Member Author

Ping @clue && @cboden

@WyriHaximus
Copy link
Member Author

Whoops totally forgot to merge this 😊 !

@WyriHaximus WyriHaximus merged commit d57bc26 into reactphp:master Dec 10, 2018
@clue clue added this to the v1.1 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsor jsor jsor approved these changes

@clue clue clue approved these changes

@cboden cboden Awaiting requested review from cboden

Assignees
No one assigned
Labels
easy pick maintenance
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@WyriHaximus @clue @jsor