Check PCNTL functions for signal support instead of PCNTL extension #195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps avoiding problems when the PCNTL extension is loaded, but
(some of) its functions are disabled via PHPs `disable_function`
configuration. This is particularly common for the PCNTL functions in
CGI environments, e.g. they are disabled by default on Debian- /
Ubuntu-based distributions. Previously, even when not attaching any
signal listeners, the loop would print a warning on each loop tick:
> PHP Warning: pcntl_signal_dispatch() has been disabled for security
reasons in {file} on {line}
jsor
approved these changes
May 7, 2019
WyriHaximus
approved these changes
May 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps avoiding problems when the PCNTL extension is loaded, but
(some of) its functions are disabled via PHPs
disable_functionconfiguration. This is particularly common for the PCNTL functions in
CGI environments, e.g. they are disabled by default on Debian- /
Ubuntu-based distributions. Previously, even when not attaching any
signal listeners, the loop would print a warning on each loop tick:
Builds on top of #179