Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix unsupported EventConfig and SEGFAULTs on shutdown for ext-event on Windows #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 28, 2019
Merged

Fix unsupported EventConfig and SEGFAULTs on shutdown for ext-event on Windows #205

merged 3 commits into from
Dec 28, 2019

Conversation

clue
Copy link
Member

@clue clue commented Dec 27, 2019 •
edited
Loading

Resolves #189
Supersedes / closes #192, thanks @inri13666 for the initial version!
Builds on top of #204

@clue clue added the bug label Dec 27, 2019
@clue clue added this to the v1.1.1 milestone Dec 27, 2019
@clue
Copy link
Member Author

clue commented Dec 27, 2019

The test suite executes just fine and all tests succeed, but it returns a SEGFAULT after running all the tests. I can reproduce the same problem locally, but this does not appear to be related to this changeset.

@clue clue changed the title Fix unsupported EventConfig for ext-event on Windows Fix unsupported EventConfig and SEGFAULTs on shutdown for ext-event on Windows Dec 27, 2019
@clue
Copy link
Member Author

clue commented Dec 27, 2019

I've fixed all SEGFAULTs by clearing all Event references in the destructor. The test suite now works without any issues on Windows :shipit:

@clue clue requested a review from WyriHaximus December 27, 2019 20:34
@clue clue mentioned this pull request Dec 28, 2019
Merged
@WyriHaximus WyriHaximus merged commit 1d8055f into reactphp:master Dec 28, 2019
@clue clue deleted the ext-event-windows branch December 29, 2019 00:56
@clue clue mentioned this pull request Dec 31, 2019
Merged
@enumag enumag mentioned this pull request Sep 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsor jsor jsor approved these changes

@WyriHaximus WyriHaximus WyriHaximus approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v1.1.1
Development

Successfully merging this pull request may close these issues.

EventBaseConfig::FEATURE_FDS not supported on Windows
3 participants
@clue @jsor @WyriHaximus