Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add feature to rename directories #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2018
Merged

Add feature to rename directories #20

merged 1 commit into from
Feb 27, 2018

Conversation

seregazhuk
Copy link
Contributor

This PR extends DirectoryInterface and adds method to rename() current directory object. The api is the same as FileInterface has:

$loop = Factory::create();
$filesystem = Filesystem::create($loop);
$dir = $filesystem->dir('new');

$dir->rename('new_name')->then(function(\React\Filesystem\Node\DirectoryInterface $newDir){
    echo 'Renamed to ' . $newDir->getPath() . PHP_EOL;
}, function(Exception $e) {
    echo 'Error: ' . $e->getMessage() . PHP_EOL;
});

WyriHaximus
WyriHaximus requested changes Feb 25, 2018
View reviewed changes
src/Node/DirectoryInterface.php Outdated
* Rename the directory and return the new directory through a promise
*
* @param string $toDirectoryName
* @return PromiseInterface<FileInterface>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be PromiseInterface<DirectoryInterface>?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, sure! Fixed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👍

@WyriHaximus WyriHaximus added this to the v0.1.1 milestone Feb 25, 2018
clue
clue reviewed Feb 26, 2018
View reviewed changes
examples/directory_rename.php Outdated
use React\EventLoop\Factory;
use React\Filesystem\Filesystem;

require '../vendor/autoload.php';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be relative to __DIR__ so that this example works irrespective of from where it is called.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

@WyriHaximus WyriHaximus merged commit 1a326f2 into reactphp:master Feb 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsor jsor jsor approved these changes

@WyriHaximus WyriHaximus WyriHaximus approved these changes

@clue clue clue approved these changes

Assignees
No one assigned
Labels
easy pick help wanted new feature
Projects
None yet
Milestone
v0.1.1
Development

Successfully merging this pull request may close these issues.
4 participants
@seregazhuk @jsor @WyriHaximus @clue