Modernize test suite #148
Merged
Modernize test suite #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
55eccba to
c4543e9
Compare
Our current test suite has been around for a while and to keep it in shape for the future we need to modernize is one in a while. With the increase to PHP 7.1+ in reactphp#149 we can also bump the PHPUnit version to 7.
c4543e9 to
b41ca0f
Compare
clue
approved these changes
Oct 8, 2019
jsor
approved these changes
Oct 8, 2019
Bilge
reviewed
Oct 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current test suite has been around for a while and to keep it in
shape for the future we need to modernize is one in a while.