Update dependencies to latest supported component versions #396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsor
approved these changes
Dec 22, 2017
|
Note that the tests are currently failing due to a number of inconsistencies across our components. I'd like to address these first and link back to this PR before getting this in 👍 |
|
Updated Socket dependency to include fix from reactphp/socket#141 There's still a failing test in react/http which I'm currently looking into 👍 |
|
Updated react/http dependency to include fix from reactphp/http#290 There's still a flaky test which fails occasionally in react/socket which I'm currently looking into 👍 |
|
Updated react/socket dependency to include fix from reactphp/socket#146 The test suite runs successfully, both locally and on Travis |
WyriHaximus
approved these changes
Jan 7, 2018
This was referenced Jan 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #395
Refs reactphp/promise-stream#11