Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update test suite and report failed assertions #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2023

Conversation

clue
Copy link
Member

@clue clue commented Mar 15, 2023

Builds on top of #491, #455, #450, reactphp/socket#299, reactphp/socket#300 and reactphp/event-loop#264.

Marking this as WIP because this is currently awaiting a number of releases. PRs reactphp/event-loop#264, reactphp/promise#241 and reactphp/stream#165 need to be released to fix PHP 8.2 compatibility for the test suite, plus reactphp/socket#299 for legacy HHVM. Additionally, PHP 8.1 and PHP 8.2 builds currently segfault, likely due to php/php-src#10496 which should be fixed in PHP 8.2.4 (tagged just yesterday, not yet available through shivammathur/setup-php). I'll make sure to update this PR once releases are available. [update 1: segfaults fixed with PHP 8.2.4 and PHP 8.1.17] [update 2: updated to all stable releases]

@clue clue added this to the v1.4.0 milestone Mar 15, 2023
@clue
Copy link
Member Author

clue commented Mar 17, 2023

Marking this as WIP because […] PHP 8.1 and PHP 8.2 builds currently segfault, likely due to php/php-src#10496 which should be fixed in PHP 8.2.4 (tagged just yesterday, not yet available through shivammathur/setup-php).

Small update: Restarted build to confirm that segfaults are indeed fixed with PHP 8.2.4 and PHP 8.1.17 releases. The PHP 8.1 build now executes successfully, the PHP 8.2 build no longer segfaults but is still broken as expected.

This PR is now only awaiting the PRs linked above, I'll make sure to update this PR once releases are available.

@clue clue force-pushed the update-tests branch 2 times, most recently from 45ad7d0 to 808ca88 Compare May 2, 2023 15:28
@clue
Copy link
Member Author

clue commented May 2, 2023

Small update: Updated now that https://github.com/reactphp/promise/releases/tag/v2.10.0 has been released. This PR is still awaiting 3 other releases linked above.

@clue clue force-pushed the update-tests branch 2 times, most recently from 36c0b78 to cd41192 Compare May 5, 2023 10:45
@clue
Copy link
Member Author

clue commented May 5, 2023

Small update: Updated now that https://github.com/reactphp/event-loop/releases/tag/v1.4.0 has been released. This PR is now still awaiting 2 other releases linked above.

@clue
Copy link
Member Author

clue commented Jun 7, 2023

Small update: Updated now that https://github.com/reactphp/socket/releases/tag/v1.13.0 has been released. This PR is now only awaiting the Stream component release linked above.

@clue clue changed the title [WIP] Update test suite and report failed assertions Update test suite and report failed assertions Jun 16, 2023
@clue clue requested review from WyriHaximus and SimonFrings June 16, 2023 14:53
@clue
Copy link
Member Author

clue commented Jun 16, 2023

Final update: Updated now that https://github.com/reactphp/stream/releases/tag/v1.3.0 has been released.

This PR no longer targets any beta releases and is now finally ready for review! :shipit:

Copy link
Member

@SimonFrings SimonFrings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Member

@WyriHaximus WyriHaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoop whoop 🎉 !

@WyriHaximus WyriHaximus merged commit 0c3c3ca into reactphp:1.x Jun 19, 2023
@clue clue deleted the update-tests branch June 19, 2023 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants