Fix HHVM build for now again and ignore future HHVM build errors #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For the reference: The build output reveals that HHVM now fails to establish any TLS sessions due to a timeout (it even fails to send an HTTPS request to Google) and I have no plans to spend any time on this right now. |
Merged
jsor
approved these changes
Jun 12, 2017
WyriHaximus
approved these changes
Jun 12, 2017
WyriHaximus
added a commit
to WyriHaximus-labs/dns
that referenced
this pull request
Jul 3, 2017
This was referenced Aug 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HHVM build reports an error once again. Let's fix this once again by updating the base distro from precise to trusty and ignore any future HHVM build errors.
See travis-ci/travis-ci#7712 (comment)
Originally from clue/reactphp-http-proxy#12