Work around Unix domain socket (UDS) paths for Mac OS X #123
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andig
added a commit
to andig/php-pm
that referenced
this pull request
Oct 7, 2017
clue
approved these changes
Oct 7, 2017
jsor
approved these changes
Oct 7, 2017
|
For the reference: This fix builds on top of #100 which landed in v0.8.0. Both are actually work-arounds for bugs in PHP, the first of which has been fixed in PHP 7.1.7 and the second has just been merged today and is due in the next PHP release. |
|
Would it be possible to release this as soon as possible? Would be nice to get UDS support into the wild without depending on dev-master. |
|
For the reference: This work-around is no longer required in PHP versions 7.0.25+ and 7.1.11+ now that the fix is in via php/php-src@843e492. This work-around does no harm and we'll keep this to support older PHP versions 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an improvement over #92 that handles the new OSX-specific failure introduced by the initial fix for https://bugs.php.net/bug.php?id=74556.