Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

clue
Copy link
Member

@clue clue commented May 31, 2024

This changeset updates the project to require PHP 7.1+ and drop legacy PHP < 7.1 and HHVM as discussed in #312. I'm marking this as a BC break for anybody still stuck on very old PHP versions, but there's little chance this will affect any current projects otherwise.

This PR aims to contain the minimal changeset to update the PHP version requirement only. Follow-up PRs will update our APIs to leverage newer language features.

Builds on top of #310 and others
Refs reactphp/cache#58

@clue clue added the BC break label May 31, 2024
@clue clue added this to the v3.0.0 milestone May 31, 2024
@clue clue requested review from WyriHaximus and SimonFrings May 31, 2024 13:50
Copy link
Member

@SimonFrings SimonFrings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went over everything, only found one small nit, but the rest looks good :)

Copy link
Member

@SimonFrings SimonFrings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, let's ship it 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants