Adding Metdata on Player (Initial Draft) (TV)#2461
Open
phisher98 wants to merge 12 commits intorecloudstream:masterfrom
Open
Adding Metdata on Player (Initial Draft) (TV)#2461phisher98 wants to merge 12 commits intorecloudstream:masterfrom
phisher98 wants to merge 12 commits intorecloudstream:masterfrom
Conversation
fire-light42
requested changes
Jan 28, 2026
Collaborator
fire-light42
left a comment
There was a problem hiding this comment.
Nice pull request. A more detailed review will be done after testing.
app/src/main/java/com/lagradost/cloudstream3/ui/player/FullScreenPlayer.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/lagradost/cloudstream3/ui/player/GeneratorPlayer.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/lagradost/cloudstream3/ui/player/GeneratorPlayer.kt
Outdated
Show resolved
Hide resolved
fire-light42
requested changes
Feb 17, 2026
Collaborator
fire-light42
left a comment
There was a problem hiding this comment.
The new UI looks really good, however I found a major UX bug. The problem is that the postDelayed never get cancelled, so pausing-unpausing repeatedly for 8 seconds will cause it to invoke the lambda several times even if you try to navigate.
Moreover, I also want to ask if it intentional to show the "Scrim" even when you navigate the UI, as you can pull up the UI by pressing Up on the dpad while paused.
app/src/main/java/com/lagradost/cloudstream3/ui/player/FullScreenPlayer.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/lagradost/cloudstream3/ui/player/FullScreenPlayer.kt
Show resolved
Hide resolved
fire-light42
approved these changes
Feb 18, 2026
Collaborator
fire-light42
left a comment
There was a problem hiding this comment.
The code looks good, will do some further testing later.
Contributor
Author
|
@fire-light42 Any more changes needed ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fade in 8 sec after paused