Add missing test case for native call #4311
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using a native call and returning first, here `array_map`, the `ReturnTypeFromStrictTypedCallRector` uses it directly and doesn't check that later `return` might return another type.
|
Nice ! Thank you. Your going so fast ! I had a look at another rule and I was about to propose using I checked your PR and see that you are using something that seems to do almost the same thing (didn't check too much). As a learning opportunity for me: why do you choose that solution over reusing |
|
|
|
Ok, I'm not there yet and I have to compare the two rules a bit more :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi !
I spotted a bug today. Here is a failling test :)
When using a native call and returning first, here
array_map, theReturnTypeFromStrictTypedCallRectoruses it directly and doesn't check that laterreturnmight return another type.I suspect this is because if the
if. With a debugger we can see thatfindCurrentScopeReturnsonly sees the return in theifscope.My contribution stops here, I don't know how what would be a good fix for this :)
Have a good day.