rectorphp · TomasVotruba · Oct 27, 2025 · Oct 27, 2025 · Oct 27, 2025
diff --git a/phpstan.neon b/phpstan.neon
@@ -222,7 +222,7 @@ parameters:
 
         - '#Register "Rector\\Php80\\Rector\\NotIdentical\\MbStrContainsRector" service to "php80\.php" config set#'
 
-        - '#Register "Rector\\Php85\\Rector\\StmtsAwareInterface\\NestedToPipeOperatorRector" service to "php85\.php" config set#'
+        - '#Register "Rector\\Php85\\Rector\\StmtsAwareInterface\\SequentialAssignmentsToPipeOperatorRector" service to "php85\.php" config set#'
 
         # closure detailed
         - '#Method Rector\\Config\\RectorConfig\:\:singleton\(\) has parameter \$concrete with no signature specified for Closure#'

diff --git a/...s/Php85/Rector/StmtsAwareInterface/NestedToPipeOperatorRector/Fixture/nested_func.php.inc b/...s/Php85/Rector/StmtsAwareInterface/NestedToPipeOperatorRector/Fixture/nested_func.php.inc
diff --git a/...85/Rector/StmtsAwareInterface/NestedToPipeOperatorRector/Fixture/skip_single_call.php.inc b/...85/Rector/StmtsAwareInterface/NestedToPipeOperatorRector/Fixture/skip_single_call.php.inc
diff --git a/...ts/Php85/Rector/StmtsAwareInterface/NestedToPipeOperatorRector/config/configured_rule.php b/...ts/Php85/Rector/StmtsAwareInterface/NestedToPipeOperatorRector/config/configured_rule.php
diff --git a/...oPipeOperatorRector/Fixture/basic.php.inc → ...oPipeOperatorRector/Fixture/basic.php.inc b/...oPipeOperatorRector/Fixture/basic.php.inc → ...oPipeOperatorRector/Fixture/basic.php.inc
@@ -1,6 +1,6 @@
 <?php
 
-namespace Rector\Tests\Php85\Rector\StmtsAwareInterface\NestedToPipeOperatorRector\Fixture;
+namespace Rector\Tests\Php85\Rector\StmtsAwareInterface\SequentialAssignmentsToPipeOperatorRector\Fixture;
 
 $value = "hello world";
 $result1 = function3($value);
@@ -11,7 +11,7 @@ $result = function1($result2);
 -----
 <?php
 
-namespace Rector\Tests\Php85\Rector\StmtsAwareInterface\NestedToPipeOperatorRector\Fixture;
+namespace Rector\Tests\Php85\Rector\StmtsAwareInterface\SequentialAssignmentsToPipeOperatorRector\Fixture;
 
 $value = "hello world";
 $result = $value

diff --git a/...ector/Fixture/inside_class_method.php.inc → ...ector/Fixture/inside_class_method.php.inc b/...ector/Fixture/inside_class_method.php.inc → ...ector/Fixture/inside_class_method.php.inc
@@ -1,6 +1,6 @@
 <?php
 
-namespace Rector\Tests\Php85\Rector\StmtsAwareInterface\NestedToPipeOperatorRector\Fixture;
+namespace Rector\Tests\Php85\Rector\StmtsAwareInterface\SequentialAssignmentsToPipeOperatorRector\Fixture;
 
 class InsideClassMethod
 {
@@ -17,7 +17,7 @@ class InsideClassMethod
 -----
 <?php
 
-namespace Rector\Tests\Php85\Rector\StmtsAwareInterface\NestedToPipeOperatorRector\Fixture;
+namespace Rector\Tests\Php85\Rector\StmtsAwareInterface\SequentialAssignmentsToPipeOperatorRector\Fixture;
 
 class InsideClassMethod
 {

diff --git a/...or/Fixture/skip_if_used_elsewhere.php.inc → ...or/Fixture/skip_if_used_elsewhere.php.inc b/...or/Fixture/skip_if_used_elsewhere.php.inc → ...or/Fixture/skip_if_used_elsewhere.php.inc
@@ -1,6 +1,6 @@
 <?php
 
-namespace Rector\Tests\Php85\Rector\StmtsAwareInterface\NestedToPipeOperatorRector\Fixture;
+namespace Rector\Tests\Php85\Rector\StmtsAwareInterface\SequentialAssignmentsToPipeOperatorRector\Fixture;
 
 $value = "hello world";
 $result1 = function3($value);

diff --git a/...Interface/SequentialAssignmentsToPipeOperatorRector/Fixture/skip_nested_functions.php.inc b/...Interface/SequentialAssignmentsToPipeOperatorRector/Fixture/skip_nested_functions.php.inc
@@ -0,0 +1,11 @@
+<?php
+
+namespace Rector\Tests\Php85\Rector\StmtsAwareInterface\SequentialAssignmentsToPipeOperatorRector\Fixture;
+
+final class SkipNestedFunctions
+{
+    public function run()
+    {
+        $result = trim(strtoupper("Hello World"));
+    }
+}
diff --git a/...AwareInterface/SequentialAssignmentsToPipeOperatorRector/Fixture/skip_single_call.php.inc b/...AwareInterface/SequentialAssignmentsToPipeOperatorRector/Fixture/skip_single_call.php.inc
@@ -0,0 +1,6 @@
+<?php
+
+namespace Rector\Tests\Php85\Rector\StmtsAwareInterface\SequentialAssignmentsToPipeOperatorRector\Fixture;
+
+$value = "hello world";
+$result1 = function3($value);
diff --git a/...Rector/NestedToPipeOperatorRectorTest.php → ...alAssignmentsToPipeOperatorRectorTest.php b/...Rector/NestedToPipeOperatorRectorTest.php → ...alAssignmentsToPipeOperatorRectorTest.php
@@ -2,13 +2,13 @@
 
 declare(strict_types=1);
 
-namespace Rector\Tests\Php85\Rector\StmtsAwareInterface\NestedToPipeOperatorRector;
+namespace Rector\Tests\Php85\Rector\StmtsAwareInterface\SequentialAssignmentsToPipeOperatorRector;
 
 use Iterator;
 use PHPUnit\Framework\Attributes\DataProvider;
 use Rector\Testing\PHPUnit\AbstractRectorTestCase;
 
-final class NestedToPipeOperatorRectorTest extends AbstractRectorTestCase
+final class SequentialAssignmentsToPipeOperatorRectorTest extends AbstractRectorTestCase
 {
     #[DataProvider('provideData')]
     public function test(string $filePath): void

diff --git a/.../StmtsAwareInterface/SequentialAssignmentsToPipeOperatorRector/config/configured_rule.php b/.../StmtsAwareInterface/SequentialAssignmentsToPipeOperatorRector/config/configured_rule.php
@@ -0,0 +1,10 @@
+<?php
+
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+use Rector\Php85\Rector\StmtsAwareInterface\SequentialAssignmentsToPipeOperatorRector;
+
+return static function (RectorConfig $rectorConfig): void {
+    $rectorConfig->rule(SequentialAssignmentsToPipeOperatorRector::class);
+};
diff --git a/...eInterface/NestedToPipeOperatorRector.php → ...entialAssignmentsToPipeOperatorRector.php b/...eInterface/NestedToPipeOperatorRector.php → ...entialAssignmentsToPipeOperatorRector.php
@@ -24,9 +24,9 @@
 
 /**
  * @see https://wiki.php.net/rfc/pipe-operator-v3
- * @see \Rector\Tests\Php85\Rector\StmtsAwareInterface\NestedToPipeOperatorRector\NestedToPipeOperatorRectorTest
+ * @see \Rector\Tests\Php85\Rector\StmtsAwareInterface\SequentialAssignmentsToPipeOperatorRector\SequentialAssignmentsToPipeOperatorRectorTest
  */
-final class NestedToPipeOperatorRector extends AbstractRector implements MinPhpVersionInterface
+final class SequentialAssignmentsToPipeOperatorRector extends AbstractRector implements MinPhpVersionInterface
 {
     public function __construct(
         private readonly ExprAnalyzer $exprAnalyzer
@@ -36,23 +36,24 @@ public function __construct(
     public function getRuleDefinition(): RuleDefinition
     {
         return new RuleDefinition(
-            'Transform nested function calls and sequential assignments to pipe operator syntax',
+            'Transform sequential assignments to pipe operator syntax',
             [
                 new CodeSample(
                     <<<'CODE_SAMPLE'
 $value = "hello world";
-$result1 = function3($value);
+$result1 = function1($value);
 $result2 = function2($result1);
-$result = function1($result2);
+
+$result = function3($result2);
 CODE_SAMPLE
                     ,
                     <<<'CODE_SAMPLE'
 $value = "hello world";
 
 $result = $value
-    |> function3(...)
+    |> function1(...)
     |> function2(...)
-    |> function1(...);
+    |> function3(...);
 CODE_SAMPLE
                 ),
             ]
@@ -80,40 +81,25 @@ public function refactor(Node $node): ?Node
 
         $hasChanged = false;
 
-        // First, try to transform sequential assignments
-        $sequentialChanged = $this->transformSequentialAssignments($node);
-        if ($sequentialChanged) {
-            $hasChanged = true;
-        }
-
-        // Then, transform nested function calls
-        $nestedChanged = $this->transformNestedCalls($node);
-        if ($nestedChanged) {
-            $hasChanged = true;
-        }
-
-        return $hasChanged ? $node : null;
-    }
-
-    private function transformSequentialAssignments(StmtsAwareInterface $stmtsAware): bool
-    {
-        $hasChanged = false;
-
-        $statements = $stmtsAware->stmts;
+        $statements = $node->stmts;
         $totalStatements = count($statements) - 1;
 
         for ($i = 0; $i < $totalStatements; ++$i) {
             $chain = $this->findAssignmentChain($statements, $i);
 
             if ($chain && count($chain) >= 2) {
-                $this->processAssignmentChain($stmtsAware, $chain, $i);
+                $this->processAssignmentChain($node, $chain, $i);
                 $hasChanged = true;
                 // Skip processed statements
                 $i += count($chain) - 1;
             }
         }
 
-        return $hasChanged;
+        if (! $hasChanged) {
+            return null;
+        }
+
+        return $node;
     }
 
     /**
@@ -243,63 +229,6 @@ private function processAssignmentChain(StmtsAwareInterface $stmtsAware, array $
         $stmtsAware->stmts = $stmts;
     }
 
-    private function transformNestedCalls(StmtsAwareInterface $stmtsAware): bool
-    {
-        $hasChanged = false;
-
-        foreach ($stmtsAware->stmts as $stmt) {
-            if (! $stmt instanceof Expression) {
-                continue;
-            }
-
-            $expr = $stmt->expr;
-
-            if ($expr instanceof Assign) {
-                $assignedValue = $expr->expr;
-                $processedValue = $this->processNestedCalls($assignedValue);
-
-                if ($processedValue instanceof Expr && $processedValue !== $assignedValue) {
-                    $expr->expr = $processedValue;
-                    $hasChanged = true;
-                }
-            } elseif ($expr instanceof FuncCall) {
-                $processedValue = $this->processNestedCalls($expr);
-
-                if ($processedValue instanceof Expr && $processedValue !== $expr) {
-                    $stmt->expr = $processedValue;
-                    $hasChanged = true;
-                }
-            }
-        }
-
-        return $hasChanged;
-    }
-
-    private function processNestedCalls(Node $node): ?Expr
-    {
-        if (! $node instanceof FuncCall) {
-            return null;
-        }
-
-        // Check if any argument is a function call
-        foreach ($node->args as $arg) {
-            if (! $arg instanceof Arg) {
-                return null;
-            }
-
-            if ($arg->value instanceof FuncCall) {
-                return $this->buildPipeExpression($node, $arg->value);
-            }
-        }
-
-        return null;
-    }
-
-    private function buildPipeExpression(FuncCall $outerCall, FuncCall $innerCall): Pipe
-    {
-        return new Pipe($innerCall, $this->createPlaceholderCall($outerCall));
-    }
-
     private function createPlaceholderCall(FuncCall $funcCall): FuncCall
     {
         return new FuncCall($funcCall->name, [new VariadicPlaceholder()]);