Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Php85] Do not convert to pipe on use directly of spread operator on NestedFuncCallsToPipeOperatorRector #7938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomasVotruba merged 4 commits into from
Mar 27, 2026
+28 −5
Merged

[Php85] Do not convert to pipe on use directly of spread operator on NestedFuncCallsToPipeOperatorRector #7938

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
01dc92c
Create spread_operator_stays.php.inc
annadamm-check24 Mar 27, 2026
071ce2a
[Php85] Do not convert to pipe on use directly of spread operator on …
samsonasik Mar 27, 2026
c2fd3b3
[ci-review] Rector Rectify
actions-user Mar 27, 2026
cf8e9c7
final touch: return
samsonasik Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[Php85] Do not convert to pipe on use directly of spread operator on … 
…NestedFuncCallsToPipeOperatorRector
  • Loading branch information
@samsonasik
samsonasik committed Mar 27, 2026
commit 071ce2a8e8eec292f9429396e309e33a545412d6
7 changes: 6 additions & 1 deletion ...ctor/Expression/NestedFuncCallsToPipeOperatorRector/Fixture/spread_operator_stays.php.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,18 @@
<?php

namespace Rector\Tests\Php85\Rector\Expression\NestedFuncCallsToPipeOperatorRector\Fixture;

$arrayOfArrays = [['a'], ['a'], ['b']];
$merged = array_unique(array_merge(...$arrayOfArrays));

?>
-----
<?php

namespace Rector\Tests\Php85\Rector\Expression\NestedFuncCallsToPipeOperatorRector\Fixture;

$arrayOfArrays = [['a'], ['a'], ['b']];
$merged = array_merge(...$arrayOfArrays)
|> array_unique(...);
|> array_unique(...);

?>
5 changes: 5 additions & 0 deletions rules/Php85/Rector/Expression/NestedFuncCallsToPipeOperatorRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,11 @@ private function processNestedCalls(Expr $expr, bool $deep = false): ?Expr

// If we're deep in recursion and hit a non-FuncCall, this is the base
if ($deep) {
// Spread argument can't be converted to pipe — keep the call as-is
if ($arg->unpack) {
return $expr;
}

// Return a pipe with the base expression on the left
return new Pipe($arg->value, $this->createPlaceholderCall($expr));
}
Expand Down
Loading