[Symfony 7.3] kick off GetFunctionsToAsTwigFunctionAttributeRector #764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2b2f050 to
14b33b7
Compare
14b33b7 to
558f0ca
Compare
samsonasik
reviewed
May 9, 2025
| public function match(Expr $expr): ?string | ||
| { | ||
| if ($expr instanceof MethodCall) { | ||
| Assert::isInstanceOf($expr->name, Identifier::class); |
There was a problem hiding this comment.
MethodCall name can be any Expr, eg variable: $foo->$bar() so this assert can cause error, should if instanceof Identifier instanceof instead
samsonasik
reviewed
May 9, 2025
| if ($expr instanceof MethodCall) { | ||
| Assert::isInstanceOf($expr->name, Identifier::class); | ||
|
|
||
| return $expr->name->toString(); |
There was a problem hiding this comment.
should only verify against $this only, as per previous approach, other object may need ClassName argument instead
samsonasik
reviewed
May 9, 2025
| return null; | ||
| } | ||
|
|
||
| if ($methodName !== 'this') { |
There was a problem hiding this comment.
Should be $varObjectName or something similar to avoid confusion of method name named "this"
There was a problem hiding this comment.
Could you resolve these? I'm already in another rule
There was a problem hiding this comment.
I created PR :
for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #761
Ref https://symfony.com/blog/new-in-symfony-7-3-twig-extension-attributes
Covering symfony/symfony#52748
Closes #760