Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Priority inheritance fix #782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 29, 2025
Merged

Priority inheritance fix #782

merged 2 commits into from
Jul 29, 2025

Conversation

yarda
Copy link
Contributor

@yarda yarda commented Jun 2, 2025

No description provided.

@yarda yarda requested a review from zacikpa June 2, 2025 21:08
@yarda
Copy link
Contributor Author

yarda commented Jun 2, 2025

/packit test

@zacikpa
Copy link
Contributor

zacikpa commented Jun 4, 2025

I'm unsure about the behavior w.r.t. the systemd system.conf files in different locations.

If I understand the manpages correctly, only the first found system.conf is loaded. Thus, if there already is some configuration in /usr/lib/systemd/system.conf and you create /etc/systemd/system.conf with just the new TuneD options, then upon systemd reload only the TuneD options will be loaded.

Secondly, I don't understand why we would want to abort the tuning when neither of /usr/lib/systemd/system.conf and /etc/systemd/system.conf exist, but proceed with the tuning when only /usr/lib/systemd/system.conf exists.

yarda added 2 commits July 28, 2025 18:11
@yarda
Fixed instance priority inheritance
94be52a 
This was caused by regression in
b10bafc.

Resolves: RHEL-94842

Signed-off-by: Jaroslav Škarvada <[email protected]>
@yarda
If plugin isn't supported, log details why it isn't supported
166102c 
Signed-off-by: Jaroslav Škarvada <[email protected]>
@yarda yarda force-pushed the priority-inheritance-fix branch from b47ea88 to 166102c Compare July 28, 2025 16:11
@yarda
Copy link
Contributor Author

yarda commented Jul 28, 2025 •
edited
Loading

After bit more thinking about it, IMHO the systemd plugin rewrite is unrelated to the subject of this PR, so fix the core bug with this PR, i.e. the priority inheritance and rewrite the systemd plugin for using dropins later in some future PR.

@yarda
Copy link
Contributor Author

yarda commented Jul 28, 2025

@zacikpa could you please review it?

@yarda
Copy link
Contributor Author

yarda commented Jul 28, 2025

CI failure seems unrelated.

zacikpa
zacikpa approved these changes Jul 29, 2025
View reviewed changes
Copy link
Contributor

@zacikpa zacikpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@yarda yarda merged commit 3554d5b into redhat-performance:master Jul 29, 2025
14 of 16 checks passed
@yarda yarda deleted the priority-inheritance-fix branch July 29, 2025 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zacikpa zacikpa zacikpa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yarda @zacikpa