Thanks to visit codestin.com
Credit goes to github.com

Skip to content

MNT: do not use deprecated load_module method #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
uglide merged 2 commits into from
Jan 30, 2026
Merged

MNT: do not use deprecated load_module method #218

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f746928
MNT: do not use deprecated load_module method
tacaswell Jan 1, 2026
c6f2147
Merge branch 'master' into fix/py315_compat
uglide Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
MNT: do not use deprecated load_module method 
The load_module method has been deprecated from py34 and will be removed in
py315 [1] (it is already gone on CPython main).

The recommended replacement is exec_module, however the documentation [2]
suggests to use a simpler approach than using the loaders directly and runpy
[3] seemed better than sys.path hacking.

Given that this is a one-line file simply reading the file and parsing it 'by
hand' is an option.

[1] https://docs.python.org/3/library/importlib.html#importlib.abc.Loader.load_module
[2] https://docs.python.org/3/library/importlib.html#importing-a-source-file-directly
[3] https://docs.python.org/3/library/runpy.html#runpy.run_path
  • Loading branch information
@tacaswell
tacaswell committed Jan 1, 2026
commit f746928e007c2e2627ba5cbdf9a0d10b37ff334e
7 changes: 2 additions & 5 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,14 @@
from setuptools import setup, Extension
except ImportError:
from distutils.core import setup, Extension
import importlib
import runpy
import glob
import io
import sys


def version():
loader = importlib.machinery.SourceFileLoader(
"hiredis.version", "hiredis/version.py")
module = loader.load_module()
return module.__version__
return runpy.run_path("hiredis/version.py")["__version__"]


def get_sources():
Expand Down
Loading