Allow calling PUBSUB CHANNELS without a pattern #2555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabbey37
commented
May 20, 2021
src/test/java/redis/clients/jedis/tests/commands/PublishSubscribeCommandsTest.java
Outdated
Show resolved
Hide resolved
10d2002 to
9547ca0
Compare
dengliming
previously approved these changes
May 21, 2021
sazzad16
suggested changes
Jun 2, 2021
src/test/java/redis/clients/jedis/tests/commands/PublishSubscribeCommandsTest.java
Outdated
Show resolved
Hide resolved
|
Just wanted to clarify that I did not intentionally dismiss @dengliming's review... I think it happened automatically when I pushed an additional commit. |
sazzad16
suggested changes
Jun 3, 2021
src/test/java/redis/clients/jedis/tests/commands/PublishSubscribeCommandsTest.java
Outdated
Show resolved
Hide resolved
src/test/java/redis/clients/jedis/tests/commands/PublishSubscribeCommandsTest.java
Outdated
Show resolved
Hide resolved
@sabbey37 Don't worry about it :) |
sazzad16
approved these changes
Jun 3, 2021
dengliming
approved these changes
Jun 4, 2021
sazzad16
pushed a commit
that referenced
this pull request
Jun 7, 2021
* Allow calling PUBSUB CHANNELS without a pattern * Edit test name * Add sentinel channel to expected channel list * Add comment regarding sentinel channel * Reverse containsAll check, update comment * Fix comment formatting
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the Redis docs at https://redis.io/commands/PUBSUB#pubsub-channels-pattern PUBSUB CHANNELS should list all channels if no pattern is specified. Currently Jedis does not support calling
pubSubChannelswithout an argument.