Add -V as short for --version #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@hbina why not just to fix the existing -v option? |
Contributor
Author
|
Hmm well you are right, I could have just fixed the old 'v'. IDK which is preferred, but you can edit this commit if you prefer that. |
5f6d12e to
bf78ce2
Compare
Contributor
Author
|
I have applied your suggestion and fixed help string to also display short name for `--help. The diff is a lot smaller now. |
yaacovhazan-Redislabs
suggested changes
Oct 20, 2020
memtier_benchmark.cpp
Outdated
| " -D, --debug Print debug output\n" | ||
| " --client-stats=FILE Produce per-client stats file\n" | ||
| " --out-file=FILE Name of output file (default: stdout)\n" | ||
| " -o --out-file=FILE Name of output file (default: stdout)\n" |
memtier_benchmark.cpp
Outdated
| " --cluster-mode Run client in cluster mode\n" | ||
| " --help Display this help\n" | ||
| " --version Display version information\n" | ||
| " -h --help Display this help\n" |
Also updated help string. Related issue: redis#139 Signed-off-by: Hanif Bin Ariffin <[email protected]>
bf78ce2 to
718df87
Compare
yaacovhazan-Redislabs
approved these changes
Oct 21, 2020
Contributor
|
thank you @hbina for the PR... merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue #139
TIL about Linux's optarg.