see #238, data import broken #240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PR includes some refactoring and cleanup around the following:
object_generator
- generate_key(), a new function that generates a key and stores it
inside internal buffer (no need for a buffer at client level)
import_object_generator
- Align it to object_generator APIs of getting key/value/expire
- read_next_item - new function for reading the next item before
creating SET command
- read_next_key - new function for reading (pointing) to the next
key before creating the GET command
data_object
- removed.
We were already getting key/value/expire separately. Now that
data-import and verify-data also moved to do it like that,
we could remove it completely.
verify_client
- unify the craate_request with its base class, and derive the
create_x_request functions.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #240 +/- ##
==========================================
+ Coverage 56.88% 62.22% +5.34%
==========================================
Files 21 21
Lines 4388 4347 -41
==========================================
+ Hits 2496 2705 +209
+ Misses 1892 1642 -250 ☔ View full report in Codecov by Sentry. |
filipecosta90
previously approved these changes
Nov 18, 2023
filipecosta90
approved these changes
Dec 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR includes some refactoring and cleanup around the following:
object_generator
inside internal buffer (no need for a buffer at client level)
import_object_generator
creating SET command
key before creating the GET command
data_object
We were already getting key/value/expire separately. Now that
data-import and verify-data also moved to do it like that,
we could remove it completely.
verify_client
create_x_request functions.