Add option to print and save all results, when performing multiple test iterations #298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This functionallity is needed since sometimes theres a need to see a specific run's results. Controlled by a new flag: --print-all-hists yes
Contributor
Author
|
@filipecosta90 anything we can do to help here? |
… of actions/download-artifact@v3. (redis#301)
…retro-compatible. Added test to confirm it.
filipecosta90
approved these changes
Feb 14, 2025
Collaborator
filipecosta90
left a comment
There was a problem hiding this comment.
@Yuval-Ariel change LGTM is and it's very useful. Did some changes and approved:
- Renamed flag to
--print-all-resultsgiven we save all data and not just the histograms and also print it. - Ensured that the change is retro compatible (meaning we still need to output best and worst results)
- Added test to this feature + retro compatible check in https://github.com/RedisLabs/memtier_benchmark/pull/298/files#diff-5c0ed236eada276ceeb3911ff98101dfce1edb93d59a32206bc8e608de4127cfR410
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This functionality is needed since sometimes theres a need to see a specific run's results.
Controlled by a new flag:
--print-all-runs