fix: improve key separator handling to avoid double separators (#368) #382
+317
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Normalize key prefixes by removing trailing separators when constructing Redis keys to prevent double separator issues (e.g., "user::123" becomes "user:123"). Changes: - Fix BaseStorage._key() to strip trailing separators from prefix - Update SemanticRouter to use index's key_separator instead of hardcoded ':' - Extract route pattern generation into reusable _route_pattern() method - Fix scan pattern generation to respect custom separators
rbs333
approved these changes
Sep 24, 2025
There was a problem hiding this comment.
Looks good! For backwards compatibility, would we have an issue if someone updates and index that had a weird prefix before and then it wouldn't reindex the data? I don't think this is a major concern but we might want to include a callout in the release notes and/or commit message to document.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normalize key prefixes by removing trailing separators when constructing
Redis keys to prevent double separator issues (e.g., "user::123" becomes
"user:123").
Changes: