Add support for immutable root reducer #159
Conversation
|
I like this! I'm curious how you're maintaining the state of the resources though? |
|
thanks for the feedback @egeriis ! What do you mean by maintaining the state of the resources ? This change is very minor, all the state management is handled by the library just the same as it does now. The important thing for this PR is that the only part which is aware of the root reducer is the actions, where we use Am I missing something else ? |
|
@gobadiah I was assuming that the entire state was Immutable.js, but the |
|
Yep that’s exactly it. Maybe in the future we could or should have the entire api state using immutable.js, but at least for now we can use an immutable root reducer.
… On 13 Apr 2018, at 16:23, Ronni Egeriis Persson ***@***.***> wrote:
@gobadiah <https://github.com/gobadiah> I was assuming that the entire state was Immutable.js, but the api scope is just plain JSON?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#159 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AB9uIimKR5ianVLodibCjcHNDGyk2qTPks5toLTHgaJpZM4S6NgV>.
|
|
Yeah, that's what I've been envisioning. Do you mind adding the docs and tests you mention? At very least documentation note about this. |
|
Okay I’ll do it, I’ll notify you here when it’s done.
… On 13 Apr 2018, at 17:36, Ronni Egeriis Persson ***@***.***> wrote:
Yeah, that's what I've been envisioning. Do you mind adding the docs and tests you mention? At very least documentation note about this.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#159 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AB9uIrqyTuz-564P3jPbnnC3DgW_Ho5Vks5toMX_gaJpZM4S6NgV>.
|
I know this has already been discussed at least here #80 and #81 .
I took a different approach from #81 to keep the core of the library agnostic regarding how the state is managed.
I did something very simple, this idea when having a root reducer immutable would be to import actions from
redux-json-api/immutableinstead ofredux-json-api.If you would be okay to integrate this, I could add documentation and some tests, I think it's important to let the developers use whatever root reducer they want.