Show Saved Replies in Comment Toolbar - #118
Conversation
| display: none; | ||
| } | ||
| .toolbar-group .js-saved-reply-container { | ||
| display: block; |
There was a problem hiding this comment.
Could you use !important for consistency?
There was a problem hiding this comment.
If you don't need !important shouldn't it be omitted? It's very heavy handed and would make it hard for this extension to be compatible with other extensions. They have to be super selective _and_use !important. It'll even override element styles you add via the inspector when you debug or play with stuff.
Personally I try to avoid using it unless really necessary, but can add it if there's a consensus to do that.
There was a problem hiding this comment.
@paulmolluzzo I'm actually saying that because of this comment from @sindresorhus: #22 (comment)
I'd prefer to not use !important, but there's a point to using it so if GitHub changes some CSS and our selector weight becomes less than GitHub selector's weight we'd need to change it. If we use !important changes are quite rarely needed. However I think CSS rules from extensions have a higher weight than the page CSS (unless the page CSS uses !important). It would be worth looking into that and removing all !important directives when not needed.
There was a problem hiding this comment.
Am I adding it to all of the styles or just the display:none?
57786fc to
a1a314d
Compare
|
Added |
|
@paulmolluzzo Hmm, I think you should either add @sindresorhus What do you think about |
|
|
a1a314d to
5f9f00c
Compare
|
OK, took it out and it's working now.
|
|
LGTM Sorry for the back-and-forth! |
|
No problem at all! Sorry I didn't realize putting |
This fixes #115. Only the Saved Replies button is shown in the comment toolbar now.